Prototype of best-chain abstractions #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
bc-abstractions
branch
4 times, most recently
from
6f87191 to
f534e21
Compare
daira
commented
Oct 18, 2023
nathan-at-least
suggested changes
Oct 18, 2023
daira
commented
Oct 19, 2023
daira
commented
Oct 19, 2023
daira
force-pushed
the
bc-abstractions
branch
4 times, most recently
from
3009fdc to
9e50b82
Compare
daira
force-pushed
the
bc-abstractions
branch
from
9e50b82 to
29831b6
Compare
daira
force-pushed
the
bc-abstractions
branch
from
29831b6 to
6899319
Compare
nathan-at-least
previously requested changes
Oct 20, 2023
There was a problem hiding this comment.
One request to delete a CI step based on the guess that it's unnecessary (because I'm allergic to unnecessary code). If it is necessary, I request we add a comment as to why (for collaborators like me where it's not obvious; it may be obvious for anyone with more github CI experience).
daira
force-pushed
the
bc-abstractions
branch
from
6899319 to
eff29f8
Compare
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
…ually_valid`. Also assert that all transactions in a `BCBlock` are `BCTransaction`s. Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
bc-abstractions
branch
from
eff29f8 to
3f66d02
Compare
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
nathan-at-least
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions for transactions, TXOs, validation contexts, and blocks. Some basic consistency rules are implemented for transactions and blocks, assuming a Bitcoin-like UTXO protocol but with explicit fees. This should be sufficient to require us to take account of UTXO-related issues like missing inputs and double-spends. Both transparent and shielded abstractions are modelled.
Left for future work: it isn't clear whether this modelling of anchors is sufficient, and we might also need to model transaction expiry.
refs #7