Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1411] Keystone integration #1431

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[#1411] Keystone integration #1431

wants to merge 19 commits into from

Conversation

LukasKorba
Copy link
Collaborator

Closes #1411

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Does the code abide by the Coding Guidelines?
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba
KS SDK bump
85dda11 
- KeystoneSDK bumped to 0.7.1, still doesn't compile
@LukasKorba
KeystoneSDK bump 0.7.2
a63531f 
- this SDK version finally works
@LukasKorba
Animated QR scanner and player
682b159 
- Ability to show & scan Animated QR code implemented
@LukasKorba
SDK Account adoption
ce7059a 
- accountIndex is not used anymore, refactored to SDK's Account
- shared state used so there is only 1 source of truth for the account
- The key for the chacged ABKeys is an Int, this could be a problem in the future
- Zip32Account addopted
@LukasKorba
Zip32AccountIndex adoption
69368cf
@LukasKorba
Add HW Wallet flow
09db171 
- Deployment target bumped up to iOS 16
- Account switch navigation bar implemented
- Accounts sheet implemented
- Add Keystone HW wallet flow implemented
@LukasKorba
Multi-account address book design
407c9c6 
- Support for multi-account has been implemented for Address book
- Handling of all possible states and scenarios (empty AB, 1 vs. many wallet acounts, from Send form vs. from Settings) tested
@LukasKorba
Internal buil 0.4.6-2
1cebbe5 
- Internal build release for the testing purposes
@LukasKorba LukasKorba changed the title [#1411] keystone integration [#1411] Keystone integration Nov 28, 2024
@LukasKorba
Receive tab multi-account support
20d7660 
- Receive tab has been extended to support HW wallet accounts
- QR code generator and logos have been updated to support multi-account
@LukasKorba
Multi-account Send flow
fce793f 
- The Send has been extended to split paths during review & confirmation into regular Zashi path and HW path
- Stacked flow for the KS sign signature done
@LukasKorba
WalletAccount UA
23117d9 
- The address string for the UI must be taken somewhere, the ideal source of truth is the account itself. The flow here is to load list of accounts without addresses ("") and fill it in later. Due to the nature of bindings in UI, it will reflect it.
@LukasKorba
Final design Vol 1
c4f854d 
- This is supposed to be final design changes, according to 2024-1-03 state
@LukasKorba
FFI adoption
7ad3073 
- AccountUUID fully adopted
- importAccount by ufvk implemented
- texts localized
@LukasKorba
deriveUnifiedAddressFromUfvk adoption
3a56601 
- Plus very first connection between KS and Zashi confirmed and tested
- transaction history now filters based on UUID
@LukasKorba
Address book zashi only
d2ca2d0 
- AB is Zashi only
- RobotoMono font for the addresses
@LukasKorba
Shielding flow and API update
9c249a0 
- the flow for sending has been updated to shielding texts - locallized
- API of the synchronizer adopted and updated
@LukasKorba
Code cleanup and preparation for the PR
cd9c5bf
@LukasKorba
Changelog updated
bd6985a
@LukasKorba LukasKorba marked this pull request as ready for review December 16, 2024 13:05
Milan-Cerovsky
Milan-Cerovsky reviewed Dec 17, 2024
View reviewed changes
Copy link

@Milan-Cerovsky Milan-Cerovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good & are in line with Android implementation/functionality. I'll do a second pass as a double check

modules/Sources/Features/AddressBook/AddressBookView.swift
.listStyle(.plain)
}

@ViewBuilder func walletAcoountView(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milan-Cerovsky Milan-Cerovsky Milan-Cerovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keystone Integration
2 participants
@LukasKorba @Milan-Cerovsky