Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the SDK does not assume a default account anywhere #1512

Open
str4d opened this issue Nov 20, 2024 · 0 comments
Open

Ensure that the SDK does not assume a default account anywhere #1512

str4d opened this issue Nov 20, 2024 · 0 comments
Assignees
@LukasKorba
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Milestone
iOS Zashi 1.3

Comments

@str4d
Copy link
Collaborator

str4d commented Nov 20, 2024

  • Various APIs take an accountId: Int argument (which will be replaced by an Account type in Refactor account representation from Int to a dedicated Account structure #1511). We need to ensure that none of these APIs are passed a default value of 0 (the default ZIP 32 account index) anywhere inside the SDK's public APIs.
  • We need to ensure that APIs returning data can do so for all accounts, either by returning all account data or having filter / Account arguments (as appropriate).
@str4d str4d added this to the iOS Zashi 1.3 milestone Nov 20, 2024
@true-jared true-jared added the S-in-progress Status: Work is currently in progress on this item. label Nov 21, 2024
@str4d str4d mentioned this issue Nov 23, 2024
Merged
14 tasks
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this issue Dec 3, 2024
@LukasKorba
[Electric-Coin-Company#1512] Ensure that the SDK does not assume a de…
35ddf87 
…fault account anywhere

- The SDK no longer assumes a default account. All business logic with instances of Zip32AccountIndex(<index>) has been refactored.
@LukasKorba LukasKorba mentioned this issue Dec 3, 2024
Merged
14 tasks
LukasKorba added a commit that referenced this issue Dec 3, 2024
@LukasKorba
Merge pull request #1516 from LukasKorba/1512-Ensure-that-the-SDK-doe…
a48a75d 
…s-not-assume-a-default-account-anywhere

[#1512] Ensure that the SDK does not assume a default account anywhere
@true-jared true-jared added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-in-progress Status: Work is currently in progress on this item. labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasKorba LukasKorba

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
iOS Zashi 1.3
Development

No branches or pull requests
3 participants
@str4d @LukasKorba @true-jared