Support HashMap as implicit type #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
commented
Feb 5, 2023
jayvdb
force-pushed
the
hashmap-implicit-type
branch
from
bc3ee10 to
7459128
Compare
jayvdb
force-pushed
the
hashmap-implicit-type
branch
from
7459128 to
faeae07
Compare
jayvdb
changed the title
jayvdb
commented
Feb 7, 2023
| @@ -113,6 +113,12 @@ impl TypeResolver { | |||
| } | |||
| } | |||
| fn find_type(&self, key: &TypeKey) -> Option<TypeIdentifier> { | |||
| #[cfg(feature = "json")] | |||
| if let TypeKey::CustomType(ct) = key { | |||
| if ct.starts_with("HashMap < String,") { | |||
There was a problem hiding this comment.
This is a horrible hack to avoid needing butane_type, which would require a newtype for each type of HashMap.
There was a problem hiding this comment.
Yeah, this is another great example of the limitations of trying to create the schema representation at compile time with only the AST and therefore why I'd like to move it to runtime.
There was a problem hiding this comment.
Since I haven't done that yet though, I'm reluctantly OK with the hack for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32