Remove unused features of dependencies #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
rm-default-features
branch
4 times, most recently
from
096085f to
2e83908
Compare
jayvdb
force-pushed
the
rm-default-features
branch
from
2e83908 to
352b077
Compare
Electron100
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am especially keen to remove the "time" crate from chrono deps, as it causes cargo-deny to fail due to https://rustsec.org/advisories/RUSTSEC-2020-0071
The one unusual bit here is disabling
perfinregex, but given how little the regex library is used, it seems to not be worthwhile using those extra perf gains https://docs.rs/regex/latest/regex/#performance-features .