Support fake data #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electron100
reviewed
Mar 4, 2023
| @@ -199,3 +202,11 @@ where | |||
| Ok(Self::from_pk(T::PKType::deserialize(deserializer)?)) | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "fake")] | |||
| /// Fake data support is currently limited to empty ForeignKey relationships. | |||
There was a problem hiding this comment.
When would this actually be useful? Since this creates an invalid ForeignKey (not fully initialized) and most of the methods will panic if called
There was a problem hiding this comment.
I guess the idea is that none of the methods would get called since you wouldn't use it with a real db connection given that it's fake data?
There was a problem hiding this comment.
Ya, at the moment the ForeignKey, and Many, are not well supported, and the user needs to know what they are doing to manually help the fake-ing process like I did in the fake test cases. Goal is for that to be automatic eventually, but at the moment this PR allows butane and fake to co-exist on the same data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.