Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing #84

Merged
merged 6 commits into from
May 11, 2023
Merged

Fix publishing #84

merged 6 commits into from
May 11, 2023

Conversation

Electron100
Copy link
Owner

Fix publishing with cargo release

  1. Fix version specifications for in-repo packages in workspace Cargo.toml
  2. Don't release butane_test_helper
  3. Don't specify version for butane_test_helper when referencing it. This allows butane_core to be published despite the circular dev-dependency. See Allow publishing with dev-dependencies without a version. rust-lang/cargo#7333

@Electron100 Electron100 mentioned this pull request May 10, 2023
Closed
jayvdb
jayvdb approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@jayvdb jayvdb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I am publishing butane_test_helper and using it in our project as a test helper, but are already adjusting its Cargo.toml before publishing.

@Electron100 Electron100 merged commit 7615017 into master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvdb jayvdb jayvdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Electron100 @jayvdb