Skip to content

Build fails for win-x64 under linux #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThuCommix opened this issue May 9, 2020 · 3 comments
Closed

Build fails for win-x64 under linux #395

ThuCommix opened this issue May 9, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@ThuCommix
Copy link

ThuCommix commented May 9, 2020

  • Version:
    • API: 8.31.1
    • CLI: 8.31.1
  • dotnet core sdk 3.1
  • nodejs 12.x
  • Target:
    • win-x64

I'm trying to setup a build for my electron app for multiple platforms: win-64x, linux-x64 and osx. After having giant trouble even with the linux build I rolled my own image and got it working. For example I needed to install the electron-builder globally because when just running electronize build I had got an error claiming that the post install of ejs failed.

However: Building for win-x64 in a docker container is currently not possible:

Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are using a supported runtime identifier, or set the PublishReadyToRun property to false

I think the flag was introduced a couple of commits ago. Is this expected behaviour or should the build work for win-x64 under linux?

Steps to Reproduce:

  1. Pull thucommix/dotnetsdk-electron:3.1_12 (for example or setup node in a dotnet sdk image yourself)
  2. Try to build any blazor starter project using: electronize /target win
@ThuCommix ThuCommix added the bug label May 9, 2020
@GregorBiswanger GregorBiswanger self-assigned this May 9, 2020
@GregorBiswanger GregorBiswanger added this to the 8.31.2 milestone May 9, 2020
@GregorBiswanger
Copy link
Member

I activated PublishReadyToRun by default because it had improved the startup speed enormously. I will build a command to disable it for the next version 8.31.2.

@ThuCommix
Copy link
Author

If you're busy I can help you out with a pull request.

@GregorBiswanger
Copy link
Member

Thanks for your offer! We can always use reinforcements :)
Trigger me on gitter, if you want to participate.

I have already implemented this feature. With the next update 8.31.2 you can use the following command:
electronize build /target win /PublishReadyToRun false

or

electronize start /PublishReadyToRun false

Alternatively, it is active by default.

GregorBiswanger added a commit that referenced this issue May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants