Skip to content

Remaining implementation of the NativeTheme API #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2020
Merged

Remaining implementation of the NativeTheme API #402

merged 3 commits into from
May 18, 2020

Conversation

konstantingross
Copy link
Contributor

'shouldUseHighContrastColors', 'shouldUseInvertedColorScheme', get/set 'themeSource' and 'updated' event added

…tColors, shouldUseInvertedColorScheme, get/set themeSource and updated event
@GregorBiswanger GregorBiswanger self-assigned this May 18, 2020
@GregorBiswanger GregorBiswanger added this to the 8.31.3 milestone May 18, 2020
Copy link
Member

@GregorBiswanger GregorBiswanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance

@GregorBiswanger GregorBiswanger merged commit 672e3b8 into ElectronNET:master May 18, 2020
@konstantingross konstantingross deleted the feature/Additional_NativeTheme_implementations branch May 18, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants