Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix frequencies for AS923 (AS923-1) to use 920-923Mhz in use by recent gateways #194

Merged
merged 2 commits into from
May 28, 2024
Merged

To fix frequencies for AS923 (AS923-1) to use 920-923Mhz in use by recent gateways #194

merged 2 commits into from
May 28, 2024

Conversation

IoTThinks
Copy link
Contributor

To use new AS923 (AS923-1) in 920-923Mhz.
Early AS923 in 923-925Mhz is obsolete and not used in many gateways.

To fix typo for some AS923 frequencies

Signed-off-by: IoTThinks.com <vinhdat82@gmail.com>
Copy link
Contributor

@REGIOIGER REGIOIGER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, the channel and data rate configuration logic is simplified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabas1080 sabas1080 merged commit a3c698a into ElectronicCats:master May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants