kdb: fix kdbGet never returns 0

ElektraInitiative · Nov 10, 2022 · 85e8e19 · 85e8e19
1 parent ad1db9d
commit 85e8e19
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/libs/elektra/kdb.c b/src/libs/elektra/kdb.c
@@ -1809,7 +1809,7 @@ int kdbGet (KDB * handle, KeySet * ks, Key * parentKey)
 		ksDel (backends);
 		ksDel (allBackends);
 		errno = errnosave;
-		return 2;
+		return ksGetSize (backends) == 0 ? 0 : 2;
 	}
 
 	// check if cache is enabled, Steps 7-9 only run with cache

diff --git a/tests/kdb/testkdb_simple.cpp b/tests/kdb/testkdb_simple.cpp
@@ -493,3 +493,11 @@ TEST_F (Simple, TriggerError)
 	ASSERT_EQ (ks.size (), 3) << "key suddenly missing";
 	ASSERT_EQ (stat (mp->systemConfigFile.c_str (), &buf), -1) << "created file even though error triggered";
 }
+
+TEST_F (Simple, NothingToDo)
+{
+	using namespace kdb;
+	KDB kdb;
+	KeySet ks;
+	EXPECT_EQ (kdb.get (ks, "system:" + testRoot), 0) << "nothing to do in get";
+}