Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Commit

Permalink
decision: apply suggestions by @kodebach
Browse files Browse the repository at this point in the history
Co-authored-by: Klemens Böswirth <23529132+kodebach@users.noreply.github.com>
  • Loading branch information
atmaxinger and kodebach authored Nov 28, 2022
1 parent 9a4b4bb commit cdf6fde
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions doc/decisions/1_in_discussion/change_tracking.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@ The library `libelektra-core` must be kept minimal.
- False positivies are okay

- this may happend when some keys may have been changed by the user, but have subsequentially been "unchanged" by a transformation plugin
Scenario: hypothetical plugin that converts all values to UPPERCASE.
- user gets key `system:/background` with value `RED`
- user changes it to `red`
- changetracking detects that value has been changed, because `RED` != `red`
- plugin changes value to UPPERCASE `RED`
Scenario: plugin that converts `false`<->`0` and `true`<->`1`
- `system:/background` is stored with value `false`
- user gets key `system:/background` with value `0` (after conversion by plugin)
- user changes it to `false`
- changetracking detects that value has been changed, because `false` != `0`
- plugin changes value from `false` to `0`
- consumers of the changetracking API will now get a false positive if they query whether `system:/background` has been changed

- False negatives are not okay
Expand Down

0 comments on commit cdf6fde

Please sign in to comment.