error/success return values ignored in elektraGetDoUpdateWithGlobalHooks()

[qwepoizt]

Problem

In several places of kdb.c return values from plugins' kdbGet() are ignored.

This leads to errors in these plugins from being ignored and not reported back to the initial caller of kdbGet().

Examples of ignored return values (list might be incomplete)

libelektra/src/libs/elektra/kdb.c

Lines 795 to 805 in 6701d9e

	case FIRST:
	keySetName (parentKey, keyName (initialParent));
	elektraGlobalGet (handle, ks, parentKey, GETSTORAGE, INIT);
	elektraGlobalGet (handle, ks, parentKey, GETSTORAGE, MAXONCE);
	break;
	case LAST:
	keySetName (parentKey, keyName (initialParent));
	elektraGlobalGet (handle, ks, parentKey, PROCGETSTORAGE, INIT);
	elektraGlobalGet (handle, ks, parentKey, PROCGETSTORAGE, MAXONCE);
	elektraGlobalError (handle, ks, parentKey, PROCGETSTORAGE, DEINIT);
	break;

libelektra/src/libs/elektra/kdb.c

Line 837 in 6701d9e

handle->globalPlugins[PROCGETSTORAGE][FOREACH]->kdbGet (handle->globalPlugins[PROCGETSTORAGE][FOREACH], ks,

libelektra/src/libs/elektra/kdb.c

Line 845 in 6701d9e

handle->globalPlugins[POSTGETSTORAGE][FOREACH]->kdbGet (handle->globalPlugins[POSTGETSTORAGE][FOREACH], ks,

libelektra/src/libs/elektra/kdb.c

Line 853 in 6701d9e

handle->globalPlugins[POSTGETCLEANUP][FOREACH]->kdbGet (handle->globalPlugins[POSTGETCLEANUP][FOREACH], ks,

libelektra/src/libs/elektra/kdb.c

Line 894 in 6701d9e

elektraGlobalGet (handle, ks, parentKey, GETSTORAGE, DEINIT);

Concrete example

One concrete example for the impact of the first example

libelektra/src/libs/elektra/kdb.c

Lines 795 to 805 in 6701d9e

	case FIRST:
	keySetName (parentKey, keyName (initialParent));
	elektraGlobalGet (handle, ks, parentKey, GETSTORAGE, INIT);
	elektraGlobalGet (handle, ks, parentKey, GETSTORAGE, MAXONCE);
	break;
	case LAST:
	keySetName (parentKey, keyName (initialParent));
	elektraGlobalGet (handle, ks, parentKey, PROCGETSTORAGE, INIT);
	elektraGlobalGet (handle, ks, parentKey, PROCGETSTORAGE, MAXONCE);
	elektraGlobalError (handle, ks, parentKey, PROCGETSTORAGE, DEINIT);
	break;

is that errors detected within elektraGoptsGet() are "swallowed".

E.g. opts.c detects a missing argument for a long option and returns false.

libelektra/src/libs/opts/opts.c

Lines 1789 to 1792 in 6701d9e

	ELEKTRA_SET_VALIDATION_SEMANTIC_ERRORF (errorKey, "Missing argument for long option: --%s",
	keyBaseName (longOpt));
	keyDel (longOpt);
	return false;

This leads to the call to elektraGlobalGet (handle, ks, parentKey, PROCGETSTORAGE, MAXONCE); at:

libelektra/src/libs/elektra/kdb.c

Line 803 in 6701d9e

elektraGlobalGet (handle, ks, parentKey, PROCGETSTORAGE, MAXONCE);

to fail.

However, the return value is ignored and thusly the error is ignored.

[qwepoizt]

@markus2330 I've discovered this and am not sure if it is a bug or intended. What do you think?

[kodebach]

Yes, this is a bug. All errors should be reported, at the very least as a warning (e.g. if there was already another error).