Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Broken artifact links failing PR builds #4624

Closed
atmaxinger opened this issue Nov 1, 2022 · 10 comments
Closed

Broken artifact links failing PR builds #4624

atmaxinger opened this issue Nov 1, 2022 · 10 comments
Labels

Comments

@atmaxinger
Copy link
Contributor

The following links in doc/INSTALL.md seem to no longer work.
This breaks at least #4554 and #4574, both are rebased on the current master branch.

doc/INSTALL.md:178:0 https://build.libelektra.org/job/libelektra/job/master/lastSuccessfulBuild/artifact/artifacts/debian-bullseye-mingw-w64-i686/elektra.zip
doc/INSTALL.md:179:0 https://build.libelektra.org/job/libelektra/job/master/lastSuccessfulBuild/artifact/artifacts/debian-bullseye-mingw-w64-x86_64/elektra.zip
@flo91
Copy link
Collaborator

flo91 commented Nov 1, 2022

I can confirm the issue.
For now, I added the two links to the linkchecker whitelist to get the PR #4506 merged.
But of course, the links should be fixed or adapted in the doc/INSTALL.md file, so that
people who read the documentation about installation get working links.

I suggest to leave this issue open until the links are fixed and removed from the whitelist.

After my PR #4506 gets merged, you should be able to merge other PRs if they are again rebased to the updated master branch.

@atmaxinger
Copy link
Contributor Author

I think you mean #4506?

@flo91
Copy link
Collaborator

flo91 commented Nov 2, 2022

Thx, that's right, I accidentally copied the wrong number from the title of the PR #4506. 👀
I corrected the PR number in the posting above yours.

@markus2330
Copy link
Contributor

I suspect we do not need to solve this issue (other then temporarily put the links to allowlist): once the javadoc issue is gone, master builds will hopefully succeed again and then these artifacts should be available again.

@markus2330
Copy link
Contributor

Unless there was a Jenkins upgrade and these links actually changed, @mpranj @lukashartl?

@mpranj
Copy link
Member

mpranj commented Nov 2, 2022

I also suspect there is nothing to do here: I think it's just that jenkins cleaned up old artifacts after n builds or days and the link went gone.
As soon as a new master build is successful the links should be OK again.

@kodebach
Copy link
Member

kodebach commented Nov 2, 2022

I think it's just that jenkins cleaned up old artifacts after n builds or days and the link went gone.

Would be pretty weird if something called lastSuccessfulBuild is automatically deleted without a newer successful build. Especially, since the last successful build was only 10 hours before this issue was opened and there were only 2 failed builds between the successful build and this issue being opened.

A separate oddity is that doc/INSTALL.md uses release builds/packages or even distro package repos, but for MinGW we just link to the latest master build. We should probably link to the latest release build instead (Note: this link works, even though the build is older).

Did someone maybe manually clean up space recently? I think there were some failed builds because of "no disk space left".

@markus2330
Copy link
Contributor

The current setting in Jenkins is that artefacts are kept 31 days but only 5 builds. I would have expected that it is 5 successful builds but maybe it is not so?

A separate oddity is that doc/INSTALL.md uses release builds/packages or even distro package repos, but for MinGW we just link to the latest master build. We should probably link to the latest release build instead (Note: this link works, even though the build is older).

I think this is a good idea. We should also add these binaries to the releases. Then we don't need the link to the latest artifacts. @mpranj what do you think?

Did someone maybe manually clean up space recently?

I only pruned docker images.

Copy link

github-actions bot commented Nov 5, 2023

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label Nov 5, 2023
Copy link

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants