Skip to content
This repository was archived by the owner on Feb 16, 2025. It is now read-only.

PR#4492 (updates for upcoming release) Review - suggestions #4506

Merged
merged 6 commits into from
Nov 6, 2022

Conversation

flo91
Copy link
Collaborator

@flo91 flo91 commented Oct 4, 2022

This are just some suggestions for improvements in the course of a review for the PR #4492.
As that PR was already merged, I decided to publish my suggested changes as a new PR.

Review:
The content of the documents looks really good. 👍🏻
I could not find a thing that is unclear or hard to understand, esp. after including the suggestions from other reviews. 💯
However, I made some changes like adding links, formatting or rephrasing.

Please review my suggested changes, thx!

@flo91 flo91 requested a review from markus2330 October 4, 2022 19:17
@flo91 flo91 self-assigned this Oct 4, 2022
Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, needs a rebase though.

@kodebach
Copy link
Member

kodebach commented Oct 9, 2022

Also: Merging this will (probably) cause conflicts in #4187. So I would suggest merging #4187 first and then rebasing this.

@markus2330
Copy link
Contributor

@flo91 can you please rebase, I would like to merge it soon. In the meeting notes there is a link to the documentation guides and it would be great if most people can already read with the fixes.

@flo91 flo91 force-pushed the PR4492Review branch 2 times, most recently from e7b5b2f to 2475ecb Compare November 1, 2022 16:31
@flo91
Copy link
Collaborator Author

flo91 commented Nov 1, 2022

Thank you for the reminder! 🔔
I almost forgot about this PR. ^^'

I've rebased with current master and added the broken links to the MinGW builds to the linkchecker whitelist. (see issue #4624)

Unfortunately, there seems to be a problem with the javadoc generation on Debian unstable, all three jobs on Debian unstable failed with the same error.
See: https://build.libelektra.org/blue/organizations/jenkins/libelektra/detail/PR-4506/7/pipeline/1093

@markus2330
Copy link
Contributor

Thank you for updating! 🚀

Did you confirm that this problem is independent of this PR? (E.g. by creating an PR with only updating release notes.) Can you change that Javadoc generation will be done on Debian stable (like other docu tasks)?

If it is not so easy, could you please create an issue?

@atmaxinger
Copy link
Contributor

@markus2330 the java doc issue is also appearing in the decision PR #4554, so it seems independent from this PR.

@markus2330
Copy link
Contributor

Please rebase after #4635

@markus2330 markus2330 merged commit 445e04f into ElektraInitiative:master Nov 6, 2022
@markus2330
Copy link
Contributor

Great job, thank you! ❤️

@mpranj mpranj added this to the 0.9.12 milestone Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants