-
Notifications
You must be signed in to change notification settings - Fork 122
PR#4492 (updates for upcoming release) Review - suggestions #4506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, needs a rebase though.
@flo91 can you please rebase, I would like to merge it soon. In the meeting notes there is a link to the documentation guides and it would be great if most people can already read with the fixes. |
e7b5b2f
to
2475ecb
Compare
Thank you for the reminder! 🔔 I've rebased with current master and added the broken links to the MinGW builds to the linkchecker whitelist. (see issue #4624) Unfortunately, there seems to be a problem with the javadoc generation on Debian unstable, all three jobs on Debian unstable failed with the same error. |
Thank you for updating! 🚀 Did you confirm that this problem is independent of this PR? (E.g. by creating an PR with only updating release notes.) Can you change that Javadoc generation will be done on Debian stable (like other docu tasks)? If it is not so easy, could you please create an issue? |
@markus2330 the java doc issue is also appearing in the decision PR #4554, so it seems independent from this PR. |
Please rebase after #4635 |
Great job, thank you! ❤️ |
This are just some suggestions for improvements in the course of a review for the PR #4492.
As that PR was already merged, I decided to publish my suggested changes as a new PR.
Review:
The content of the documents looks really good. 👍🏻
I could not find a thing that is unclear or hard to understand, esp. after including the suggestions from other reviews. 💯
However, I made some changes like adding links, formatting or rephrasing.
Please review my suggested changes, thx!