MSR: replace grep -P with sed #1301
Conversation
There was a problem hiding this comment.
@sanssecours Are the string concatenation problems fixed now, too?
| @@ -101,7 +101,7 @@ sudo kdb mount main.ini /examples/conditionals ni | |||
| sudo kdb mount sub.ini /examples/conditionals/sub ini | |||
|
|
|||
| # mount conditionals as global plugin | |||
| sudo kdb global-mount conditionals | |||
| sudo kdb global-mount conditionals || $(exit 0) | |||
There was a problem hiding this comment.
I added #1306 to revert this later
| @@ -113,9 +113,9 @@ EOF | |||
| echo "key = false" > `kdb file /examples/conditionals/sub` | |||
|
|
|||
| # should fail and yield an error | |||
| kdb export /examples/conditionals ini | |||
| #> sub/key = false | |||
| kdb export /examples/conditionals simpleini | |||
There was a problem hiding this comment.
We should avoid simpleini, it currently does not work on macOS. (In particular such a change is strange in a PR attempting to do macOS fixes 😆) Any reason why you used it here?
There was a problem hiding this comment.
oh, didn't know that.
i changed it to simpleini because it's easier to read in tutorial after ini started to support metakeys (the metakey would be printed to stdout too)
i could add a nometa flag to ini though.
There was a problem hiding this comment.
@sanssecours said he will add a simpleini replacement for MacOS. #701
We should not make ini even more complicated.
| @@ -129,9 +129,9 @@ kdb export /examples/conditionals ini | |||
| kdb set /examples/conditionals/sub/key true | |||
|
|
|||
| # should succeed | |||
| kdb export /examples/conditionals ini | |||
| #> sub/key = true | |||
| kdb export /examples/conditionals simpleini | |||
|
Thank you! Already merged as part of #1456 |
Purpose
replaced
grep -Pwithsed