Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Elektra Highlevel API #1605

Closed
wants to merge 143 commits into from
Closed

Conversation

domhof
Copy link
Contributor

@domhof domhof commented Sep 13, 2017

Purpose

  • Added support for enums and arrays
  • Improved formatting of generated code
  • Fixed key-normalization (trailing / and /# get removed as well)
  • Fixed code generation for string default values
  • Eliminated some public helper methods (fewer auto completion suggestions in IDEs makes it easier for developers to find the right elektra method)
  • Removed error enums from error specification file (instead we use the raw error code)
  • Improved enum(-array) support
  • Index argument before value in array getters/setters
  • Always require default value
  • Getters/Setters that allow specification of the value type at runtime

TODO:

  • Dokumentation
  • More testing

Checklist

Please only check relevant points.
For docu fixes, spell checking and similar nothing
needs to be checked.

  • commit messages are fine (with references to issues)
  • I ran all tests and everything went fine
  • I added unit tests
  • affected documentation is fixed
  • I added code comments, logging, and assertions
  • meta data is updated (e.g. README.md of plugins)

@markus2330 please review my pull request

@markus2330 markus2330 added this to the 0.8.21 milestone Nov 3, 2017
@markus2330
Copy link
Contributor

markus2330 commented Nov 3, 2017

I tagged this PR with 0.8.21, it is time to finally get this merged. Can you please finish this PR (docu, tutorial, leftovers).

Also a rebase is required.

@markus2330
Copy link
Contributor

Please avoid merges for such large PRs that create new functionality. Please rebase instead.

Is this ready for review? Please tag accordingly.

@markus2330 markus2330 removed this from the 0.8.21 milestone Dec 17, 2017
@markus2330 markus2330 mentioned this pull request Mar 25, 2018
9 tasks
@markus2330 markus2330 mentioned this pull request Jun 2, 2018
6 tasks
@markus2330 markus2330 mentioned this pull request Jun 27, 2018
@markus2330
Copy link
Contributor

Superseded by #2293

@markus2330 markus2330 closed this Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants