Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Markdown Shell Recorder: Add Partial Support for Indented Code Blocks #2002

Merged
merged 9 commits into from
May 17, 2018

Conversation

sanssecours
Copy link
Member

Purpose

This pull request should fix the problems of the Markdown Shell Recorder test of the Hexnumber plugin (see PR #1903).

Checklist

  • I checked all commit messages.
  • I ran all tests locally and everything went fine.
  • This PR contains an updated version of the release notes.

@sanssecours
Copy link
Member Author

sanssecours commented May 17, 2018

@ingwinlu 👋 Can you please tell me how I can restart pr-merge? It also seems the configuration for “Blue Ocean” is broken:

jenkins

. At least the page for the URL https://build.libelektra.org/jenkins/blue/organizations/jenkins/libelektra/detail/PR-2002/9 stays blank in my browser.

@ingwinlu
Copy link
Contributor

I noticed problems yesterday due to your branchname but thought it resolved itself as soon as you opened the PR. For me the url is loading.

anyway you can trigger a rebuild via 'jenkins build libelektra please'.

@sanssecours
Copy link
Member Author

Thank you for the quick response.

For me the url is loading.

Seems this is a Safari specific problem, as the page works in Opera.

@ingwinlu
Copy link
Contributor

Thank you for the quick response.

No worries.

Please do not delete the source branch I might have to use it in a bug report against jenkins as it breaks the ui.

@markus2330
Copy link
Contributor

I also can keep the PR open (at least for some time), did you write the bug against Jenkins already?

@sanssecours What does "partial support" mean? Can you document that please?

@ingwinlu
Copy link
Contributor

Having the branch alone is enough. And no I have not gotten around to it yet.

@sanssecours
Copy link
Member Author

What does "partial support" mean?

It’s not really supported, but some things – e.g. the MSR test from #1903 – might nevertheless work.

Can you document that please?

Before I do that, I might even add full support for that stuff. It seems like everybody assumes that indented code blocks work anyway.

@markus2330 markus2330 merged commit 3ae51be into ElektraInitiative:master May 17, 2018
@markus2330
Copy link
Contributor

Thank you for the great work!

@sanssecours Would be great to see full support 😉 Do not forget to not remove the branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants