This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Highlevel-API Improvements #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodebach
commented
Jan 17, 2019
| @@ -253,7 +253,7 @@ void elektraFatalError (Elektra * elektra, ElektraError * fatalError); | |||
| * | |||
| **************************************/ | |||
|
|
|||
| const char * elektraGetValue (Elektra * elektra, const char * name); | |||
| const char * elektraGetRawString (Elektra * elektra, const char * name); | |||
There was a problem hiding this comment.
@markus2330 I didn't remove this function, because elektraSetRawString (previously elektraSetValue) is actually needed for code-generation and having a public setter without the corresponding getter seemed weird. I think RawString describes better what the function actually does.
Also I thought it might be useful to have this function, if a user wants to extend the API with a custom type (e.g. something like BigInteger from Java). Users could write their own functions that check the type with elektraGetType and the use elektraGetRawString followed by some custom conversion.
|
Thank you, great work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are further improvements to the highlevel-API as requested in #2293.
@markus2330 please review my pull request