Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Move conversion functions from highlevel to ease #2916

Merged
merged 7 commits into from
Aug 31, 2019

Conversation

kodebach
Copy link
Member

Basics

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see Coding Guidelines)
  • meta data is updated (e.g. README.md of plugins and METADATA.ini)

Review

@kodebach

This comment has been minimized.

@markus2330
Copy link
Contributor

Thank you for creating this PR! Great idea to move them.

@kodebach
Copy link
Member Author

@markus IMO this is ready to merge, link-checker won't work (see #2915 (comment))

@markus2330
Copy link
Contributor

Thank you! I'll merge soon (I wait for the master build to complete)

@markus2330 markus2330 merged commit 84d5feb into ElektraInitiative:master Aug 31, 2019
@kodebach kodebach mentioned this pull request Aug 31, 2019
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants