Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

CI: update macOS images and various fixes #3639

Merged
merged 22 commits into from
Apr 6, 2021

Conversation

mpranj
Copy link
Member

@mpranj mpranj commented Jan 30, 2021

Fixes multiple CI issues.

Closes #3635.

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💖

doc/COMPILE.md Outdated
| gcc | 9.1 | macOS |
| gcc/g++ | 4.9.4 (¹) | openbsd 6.3 |
| mingw | 6.0.0-3 | amd64 |
| clang | 6.0.0 | freebsd 11 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we drop all our openbsd/freebsd buildjobs?

Isn't there any job anymore with older compilers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed to the wrong branch here but regardless:

The compilers from our CI can be seen at any time and the document links to the Dockerfiles, Jenkins etc. (thus removal of FreeBSD ..)

In #3384 we discussed that this list should only contain the manually tested setups by developers. I re-started the list and I hope others will add to it. I do fear that it will get outdated again to be honest. To my knowledge none of us are currently testing neither on OpenBSD nor on ancient GCC versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then the introducing sentence is confusing, I made a suggestion.

Yeah, it will easily get outdated again. Probably we should remove this manually-written list in the long term and instead simply refer to Dockerfiles etc. instead.

I already suggested to @robaerd that it would be great if the build jobs would do a cc --version in the beginning so that the version info always gets printed and is easily discoverable.

@@ -5,7 +5,7 @@
- infos/provides =
- infos/recommends =
- infos/placements = pregetcache postgetcache
- infos/status = maintained unittest shelltest specific global
- infos/status = maintained unittest shelltest specific nodep global
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except of (maybe) this change, I think most of these fixes from the auto heuristics do not improve the situation or are even wrong.

E.g. ccode is afaik configurable, it supports /escape and /chars. It only misses the docu how to do it, so probably it should have nodoc. I wouldn't waste too much time on reclassify everything, as this is planned in #3590 anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I will revert these auto-generated changes to avoid errors.

doc/COMPILE.md Outdated Show resolved Hide resolved
@mpranj mpranj changed the title cirrus: restart dbus service before running tests, fixes #3635 CI: various fixes Apr 3, 2021
@mpranj mpranj changed the title CI: various fixes CI: update macOS images and various fixes Apr 3, 2021
@mpranj mpranj marked this pull request as ready for review April 6, 2021 13:18
@mpranj mpranj added this to the 0.9.5 milestone Apr 6, 2021
@mpranj mpranj merged commit 6b228bf into ElektraInitiative:master Apr 6, 2021
@mpranj mpranj deleted the fix_3635 branch April 21, 2021 12:06
@kodebach kodebach mentioned this pull request Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cirrus: dbus memory leak on 🍎 Clang ASAN
2 participants