Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[CM H2] Third party licensing cleanup #3830

Conversation

a-kraschitzer
Copy link
Contributor

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

@a-kraschitzer a-kraschitzer force-pushed the third_party_licensing_cleanup branch 3 times, most recently from 38898e1 to 9e9112b Compare May 10, 2021 06:40
@a-kraschitzer
Copy link
Contributor Author

@markus2330 I don't know why the bashisms test is failing. I tried

$ checkbashisms check-third-party-license-file-paths
could not find any possible bashisms in bash script check-third-party-license-file-paths

Please advise.

@markus2330
Copy link
Contributor

I agree this is unrelated to your script. This looks to me like the "you may get strange results" suddenly bit us. Maybe it is already resolved, @mpranj has done some fixes for exclusion of scripts. We probably need to exclude the files which are neither scripts nor have a shebang, I opened #3834.

@a-kraschitzer a-kraschitzer force-pushed the third_party_licensing_cleanup branch from 9e9112b to 145ec19 Compare May 10, 2021 22:43
@markus2330 markus2330 merged commit 4da0d2a into ElektraInitiative:master May 12, 2021
@markus2330
Copy link
Contributor

Thank you so much for these fixes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants