Skip to content
This repository was archived by the owner on Feb 16, 2025. It is now read-only.

Aaronabebe spec tutorial #3915

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Aaronabebe spec tutorial #3915

merged 5 commits into from
Jul 8, 2021

Conversation

markus2330
Copy link
Contributor

@markus2330 markus2330 commented Jul 3, 2021

Closes #1522.
Continuation of #3913.

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

@mpranj mpranj added this to the 0.9.7 milestone Jul 7, 2021
@mpranj mpranj merged commit 4497a45 into master Jul 8, 2021
@mpranj
Copy link
Member

mpranj commented Jul 8, 2021

Thank you @aaronabebe for the specification tutorial!

@mpranj mpranj deleted the aaronabebe-spec-tutorial branch July 8, 2021 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Interactive Tutorial
3 participants