Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[#3742] Cascading writes #4908

Closed
wants to merge 4 commits into from
Closed

[#3742] Cascading writes #4908

wants to merge 4 commits into from

Conversation

hannes99
Copy link
Contributor

@hannes99 hannes99 commented Apr 21, 2023

Disable cascading writes(fixes #3742), add new tests and update existing tests and docs. This also fixes #4028

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@hannes99 hannes99 requested review from flo91 and tmakar April 21, 2023 17:50
@hannes99 hannes99 changed the title [#3742]Cascading writes [#3742] Cascading writes Apr 21, 2023
src/tools/kdb/export.cpp Fixed Show fixed Hide fixed
src/tools/kdb/mv.cpp Outdated Show resolved Hide resolved
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

src/tools/kdb/export.cpp Outdated Show resolved Hide resolved
src/tools/kdb/rm.cpp Show resolved Hide resolved
@tmakar
Copy link
Contributor

tmakar commented Apr 22, 2023

After that use the command:

	cat man.patch | patch -p1

to apply the changes.

@hannes99 Regarding the man pages patch. Just copy the diff into a man.patch.

@tmakar
Copy link
Contributor

tmakar commented Apr 22, 2023

jenkins build libelektra please

@hannes99 hannes99 removed the request for review from flo91 April 22, 2023 14:38
@hannes99 hannes99 force-pushed the cascading-writes branch 3 times, most recently from 1cd9be9 to 82fb1f6 Compare April 23, 2023 04:02
@hannes99 hannes99 requested a review from atmaxinger April 23, 2023 07:01
doc/help/kdb-find.md Outdated Show resolved Hide resolved
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

2 similar comments
@atmaxinger
Copy link
Contributor

jenkins build libelektra please

@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@atmaxinger atmaxinger mentioned this pull request Apr 28, 2023
31 tasks
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

2 similar comments
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@hannes99 hannes99 requested a review from atmaxinger April 29, 2023 05:32
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

1 similar comment
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@atmaxinger
Copy link
Contributor

You can stop doing this, this is a general error on our build server. It needs to be fixed first.

@tmakar
Copy link
Contributor

tmakar commented May 3, 2023

@hannes99 Please rebase!

@hannes99 hannes99 force-pushed the cascading-writes branch from fe5d65a to 99502a6 Compare May 6, 2023 03:22
@hannes99
Copy link
Contributor Author

hannes99 commented May 6, 2023

jenkins build libelektra please

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannes99 pls rebase

@hannes99
Copy link
Contributor Author

done

Copy link

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new PR with the remainder of this PR.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label Jun 14, 2024
Copy link

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new PR with the remainder of this PR.
Thank you for your contributions 💖

@github-actions github-actions bot closed this Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kdb set uses default: on cascading writes kdb disable cascading writes
4 participants