-
Notifications
You must be signed in to change notification settings - Fork 122
Webd
and elektrad
bulk kdb meta-set
#4910
Webd
and elektrad
bulk kdb meta-set
#4910
Conversation
This PR introduces:
|
Webd
and elektrad
bulk kdb meta-set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this looks okay from a pure idea standpoint. However, I can't review the code, as I've never seen a single line of Go code in my life.
It's also a bit off-putting that there are no tests, but apparently, there are no existing tests for elektrad or webd either.
Yes, I noticed this as well. I now thought that it is better to put at least a shell-recorder test into the I will may in the next iterations work on adding tests, at least for the |
@atmaxinger There actually are tests for |
please rebase to resolve merge conflict |
…th multiple metakeys
108fb5e
to
ce70a98
Compare
jenkins build libelektra please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Basics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels