Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Add shell test case for parent array spec bug #4918

Merged
merged 8 commits into from
May 9, 2023

Conversation

tmakar
Copy link
Contributor

@tmakar tmakar commented May 2, 2023

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@tmakar tmakar linked an issue May 2, 2023 that may be closed by this pull request
@tmakar tmakar force-pushed the spec-array-parents-bug branch 4 times, most recently from 28dc5a6 to a944384 Compare May 2, 2023 21:57
@tmakar tmakar requested a review from markus2330 May 3, 2023 05:43
@tmakar tmakar force-pushed the spec-array-parents-bug branch from c213ba1 to 37b4e7c Compare May 3, 2023 07:25
@tmakar
Copy link
Contributor Author

tmakar commented May 3, 2023

jenkins build libelektra please

@tmakar tmakar requested review from atmaxinger and hannes99 May 3, 2023 09:57
@tmakar tmakar force-pushed the spec-array-parents-bug branch from 37b4e7c to e5f7edf Compare May 3, 2023 10:17
@tmakar tmakar requested review from kodebach and removed request for atmaxinger May 3, 2023 13:59
Copy link
Member

@kodebach kodebach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmakar tmakar requested review from atmaxinger and hannes99 and removed request for hannes99 and atmaxinger May 3, 2023 14:51
Copy link
Contributor

@hannes99 hannes99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tmakar
Copy link
Contributor Author

tmakar commented May 9, 2023

@markus2330 can be merged!

@tmakar tmakar force-pushed the spec-array-parents-bug branch from 44765e4 to c741bdc Compare May 9, 2023 09:36
@tmakar tmakar requested a review from atmaxinger May 9, 2023 09:49
Copy link
Contributor

@atmaxinger atmaxinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atmaxinger atmaxinger merged commit d328680 into ElektraInitiative:master May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix handling of array parents in spec plugin
5 participants