rename updates #593
rename updates #593
Conversation
| return 1; /* success */ | ||
| } | ||
|
|
||
| Plugin * ELEKTRA_PLUGIN_EXPORT (rename) | ||
| { | ||
| // clang-format off |
There was a problem hiding this comment.
I think its nicer when you leave this customized formatted, don't you agree?
There was a problem hiding this comment.
i honestly have no idea why that line always disappears...
|
Thank you! Now only the profile plugin and we should be done with new features for this release! Can you add test cases for the new features? There are memory problems reported by build server. I do not have time for a closer look today, sorry! |
|
@markus2330 done |
| @@ -1,9 +1,9 @@ | |||
| /** | |||
| * @file | |||
| * \file | |||
There was a problem hiding this comment.
@ is the correct one, see doc/CODING.md
|
What does the |
|
Any progress here? The issues should only be minor? |
|
@markus2330 done |
| @@ -203,23 +228,16 @@ static Key * restoreKeyName (Key * key, const Key * parentKey, const Key * confi | |||
| { | |||
| if (strcmp (keyString (origNameKey), keyName (key))) | |||
| { | |||
| int hasSync = keyNeedSync (key); // test_bit(key->flags, KEY_FLAG_SYNC); | |||
There was a problem hiding this comment.
Why did you remove these lines which restore the sync bit? They are needed for #404. We should always put comments above lines that fix a bug so that everyone know what they are for.
| @@ -1,9 +1,9 @@ | |||
| /** | |||
| * @file | |||
| * | |||
| * @brief A plugin that converts keys to metakeys and vice versa | |||
| * \brief A plugin that converts keys to metakeys and vice versa | |||
There was a problem hiding this comment.
please change, it should be @
| @@ -207,11 +234,6 @@ static Key * restoreKeyName (Key * key, const Key * parentKey, const Key * confi | |||
| Key * result = keyDup (key); | |||
| keySetName (result, keyString (origNameKey)); | |||
| keySetMeta (result, ELEKTRA_ORIGINAL_NAME_META, 0); | |||
|
|
|||
| if (!hasSync) | |||
There was a problem hiding this comment.
Still removed. Could you also please add a comment that it is here because of #404. (At all places)
|
@markus2330 done |
|
Thank you! |
like this ?
get/case will be applied initially to the keyset, then the normal transformations are done.
on set the keyname will be either:
restored and converted to lower or uppercase depending on set/case
of
if set/case == keyname: not restored and the transformed name kept.