Allow apt preferences #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thir820
force-pushed
the
allow_apt_preferences
branch
2 times, most recently
from
d238ab2 to
852a97d
Compare
|
@MofX The preferences only have an effect for not installed packages. Downgrading already installed packages using preferences doesn't work. |
thir820
force-pushed
the
allow_apt_preferences
branch
from
852a97d to
4674d0b
Compare
MofX
reviewed
Jan 24, 2025
thir820
force-pushed
the
allow_apt_preferences
branch
from
4674d0b to
3b7b969
Compare
|
@MofX Review findings are fixed and test re-run: (.venv) (venv) ebcl@bce84abd09b2:/workspace$ pytest
======================================================================================= test session starts ========================================================================================
platform linux -- Python 3.10.12, pytest-8.3.3, pluggy-1.5.0
rootdir: /workspace
configfile: pyproject.toml
testpaths: tests
plugins: cov-6.0.0
collected 89 items
tests/hypervisor/test_model.py ........... [ 12%]
tests/test_apt.py ......... [ 22%]
tests/test_boot.py .. [ 24%]
tests/test_cache.py ........ [ 33%]
tests/test_config.py ..... [ 39%]
tests/test_deb.py .. [ 41%]
tests/test_dependency.py .. [ 43%]
tests/test_fake.py .... [ 48%]
tests/test_files.py ................... [ 69%]
tests/test_initrd.py ........ [ 78%]
tests/test_proxy.py ....... [ 86%]
tests/test_root.py .ssss.. [ 94%]
tests/test_version.py ..... [100%]
============================================================================= 85 passed, 4 skipped in 69.63s (0:01:09) =============================================================================
(.venv) (venv) ebcl@bce84abd09b2:/workspace$ cd robot_tests/
(.venv) (venv) ebcl@bce84abd09b2:/workspace/robot_tests$ robot *.robot
==============================================================================
Boot & Initrd & Root
==============================================================================
Boot & Initrd & Root.Boot
==============================================================================
Kernel exists | PASS |
------------------------------------------------------------------------------
Config is OK | PASS |
------------------------------------------------------------------------------
Script was executed | PASS |
------------------------------------------------------------------------------
Boot & Initrd & Root.Boot | PASS |
3 tests, 3 passed, 0 failed
==============================================================================
Boot & Initrd & Root.Initrd
==============================================================================
Root Device is Mounted | PASS |
------------------------------------------------------------------------------
Devices are Created | PASS |
------------------------------------------------------------------------------
Rootfs should be set up | PASS |
------------------------------------------------------------------------------
File dummy.txt should be OK | PASS |
------------------------------------------------------------------------------
File other.txt should be OK | PASS |
------------------------------------------------------------------------------
Modules are installed | PASS |
------------------------------------------------------------------------------
Check modules loaded by init | PASS |
------------------------------------------------------------------------------
Boot & Initrd & Root.Initrd | PASS |
7 tests, 7 passed, 0 failed
==============================================================================
Boot & Initrd & Root.Root
==============================================================================
Systemd should exist | PASS |
------------------------------------------------------------------------------
Fakeoot config executed | PASS |
------------------------------------------------------------------------------
Fakechroot config was executed | PASS |
------------------------------------------------------------------------------
Chroot config was executed | PASS |
------------------------------------------------------------------------------
Boot & Initrd & Root.Root | PASS |
4 tests, 4 passed, 0 failed
==============================================================================
Boot & Initrd & Root | PASS |
14 tests, 14 passed, 0 failed
==============================================================================
Output: /workspace/robot_tests/output.xml
Log: /workspace/robot_tests/log.html
Report: /workspace/robot_tests/report.html |
MofX
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow apt preferences by applying file overlays after apt config generation.
This allows overwriting the generated apt configuration and adding additional configs like apt preferences.
Dependencies:
none
Tests results
Developer Checklist:
Reviewer checklist: