Add integration tests using the spread framework #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on the following PRs being merged in spread upstream:
And depends on this PR in nemos-images: #16 |
|
Example test result: |
IsaacJT
force-pushed
the
add-spread-tests
branch
from
e79f604 to
581cb12
Compare
|
Really cool stuff and I like it. At EB the testing team seems to use the robot framework through qemu, thus a similar approach but with different tools. It might be valuable to communicate the way you (Canonical) drives the tests to the EB QA team in the next meeting. What do you think ? I really like the combination of spread and github workflows, this is cool stuff |
|
Yes sounds good, would be great to do a deep dive on this topic together. I'll add it as a topic to next week's technical call. Spread was mostly developed for snapd - if you're curious you can see it in action with a massive matrix of tests that are carried out for each PR: https://github.com/snapcore/snapd/actions/workflows/test.yaml |
IsaacJT
force-pushed
the
add-spread-tests
branch
from
581cb12 to
0434174
Compare
IsaacJT
force-pushed
the
add-spread-tests
branch
2 times, most recently
from
3f9ec37 to
988e7da
Compare
…emove bash Bash is needed for the spread automated testing suite, and we do not have a hard requirement to remove it in the everything-enabled reference image, so we can leave it installed. Signed-off-by: Isaac True <isaac.true@canonical.com>
Quote the YAML values and specify DEBIAN_FRONTEND=noninteractive to ensure that apt does not freeze waiting on user input that will never come. Signed-off-by: Isaac True <isaac.true@canonical.com>
IsaacJT
force-pushed
the
add-spread-tests
branch
2 times, most recently
from
2bf61bf to
290213d
Compare
IsaacJT
force-pushed
the
add-spread-tests
branch
2 times, most recently
from
498c460 to
9d262ec
Compare
This adds the required files for running tests inside generated VM images using the spread framework (https://github.com/snapcore/spread). Spread tests can be run by running the following commands (the build directory refers to the location where the Kiwi images were built): ``` mkdir -p ~/.spread/adhoc cp build/nemos-image-minimal-lunar.x86_64-1.0.1.qcow2 \ ~/.spread/adhoc/nemos-image-minimal-lunar.qcow2 cp build/nemos-image-reference-lunar.x86_64-1.0.1.qcow2 \ ~/.spread/adhoc/nemos-image-reference-lunar.qcow2 spread -v adhoc: ``` Signed-off-by: Isaac True <isaac.true@canonical.com>
|
@schaefi this is ready for review now |
schaefi
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds the required files for running tests inside generated VM images using the spread framework (https://github.com/snapcore/spread).
Spread tests can be run by running the following commands (the build directory refers to the location where the Kiwi images were built):
These tests can be used to automatically verify that features are present and enabled in the generated images.