Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: fix remove nested data not re-render element #15002

Closed
wants to merge 1 commit into from

Conversation

Hazlank
Copy link
Contributor

@Hazlank Hazlank commented Apr 8, 2019

fix #14998

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit caf9433

https://deploy-preview-15002--element.netlify.com

@ziyoung
Copy link
Contributor

ziyoung commented Apr 12, 2019

In fact, Vue can detect the change of array. https://jsfiddle.net/tLzna7oy/.
https://vuejs.org/v2/api/index.html#vm-watch

you don’t need to do so to listen for Array mutations.

@Hazlank
Copy link
Contributor Author

Hazlank commented Apr 15, 2019

@ziyoung 是的,但是嵌套的数组或者对象并不能够触发外层的watch?只有在deep为true的时候,才会递归的把外层的watch添加进嵌套数据的dep里,这样嵌套数据在监听变动时触发dep.notify时才能够执行到外层的watch吧

@ziyoung ziyoung changed the title Table: fix remove nested data not re-render element (#14998) Table: fix remove nested data not re-render element Apr 23, 2019
@ziyoung ziyoung self-requested a review May 7, 2019 02:52
@ziyoung ziyoung added this to the 2.9.0 milestone May 7, 2019
@ziyoung ziyoung closed this May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Don't remove child's DOM element in element-ui table with children
3 participants