Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing description to Alert component #15444

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Docs: add missing description to Alert component #15444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/docs/en-US/alert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ Description includes a message with more detailed information.

| Name | Description |
|------|--------|
| — | description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| description | ... |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<p class="el-alert__description" v-if="$slots.default && !description"><slot></slot></p>

I saw a similar code where the default slot is "—" and this slot is used for description.

So.. What needs to be corrected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault.

| title | content of the Alert title |

### Events
Expand Down
1 change: 1 addition & 0 deletions examples/docs/es/alert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ Descripción incluye un mensaje con información más detallada.

| Name | Description |
|------|--------|
| — | descripción |
| title | El contenido del título de alerta. |

### Eventos
Expand Down
1 change: 1 addition & 0 deletions examples/docs/fr-FR/alert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ Contient un message avec plus d'informations.

| Nom | Description |
|------|--------|
| — | la description |
| title | Le contenu du titre. |

### Évènements
Expand Down
1 change: 1 addition & 0 deletions examples/docs/zh-CN/alert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ Alert 组件提供了两个不同的主题：`light`和`dark`。

| Name | Description |
|------|--------|
| — | 描述 |
| title | 标题的内容 |

### Events
Expand Down