Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input : Optimization input line-height tree：add attributes all-disabled #16568

Closed
wants to merge 19 commits into from
Closed

Input : Optimization input line-height tree：add attributes all-disabled #16568

wants to merge 19 commits into from

Conversation

xrkffgg
Copy link

@xrkffgg xrkffgg commented Jul 15, 2019 •
edited
Loading

NO1. commits input

  1. 修正文档 input 中 size 类型选项文字，将 large 修改为 medium
  2. 根据 PR Input: fix clear icon is not centered #15354 发现，icon 的 line-height 根据 el-input__icon 进行改变，当 input size 改变时，改变了 inner 和 icon 的 height 或 line-height，这里将其优化为 修改 el-input 的 height 和 line-height。npm run test 测试无误

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@xrkffgg
<input>:<1、修正文档中size类型选项文字，将large修改为medium；2、根据 #15354 发现，icon的line-h…
491a145 
…eight根据el-input__icon进行改变，当input size改变时，改变了inner 和 icon 的height或line-height，这里将其优化为 修改el-input 的 height 和 line-height。test测试无误>
@element-bot
Copy link
Member

element-bot commented Jul 15, 2019 •
edited
Loading

Deploy preview for element ready!

Built with commit 3fd8f4d

https://deploy-preview-16568--element.netlify.com

@xrkffgg
1、tree 组件增加 all-disabled 属性，可直接将所有节点的选择框 设置为禁用状态；
7ab369d 
2、types 中 增加 allDisabled 变量设置说明；
3、中文文档增加 演示例子，Attributes 中 增加 all-disabled 说明，props 中增加了一个标点
@xrkffgg xrkffgg changed the title Input : Optimization input line-height Input : Optimization input line-height tree：add attributes all-disabled Jul 16, 2019
@xrkffgg
Copy link
Author

xrkffgg commented Jul 16, 2019 •
edited
Loading

NO2. commits tree

tree-all-disabled 的 官网测试预览：

属性设置：

@xrkffgg
Copy link
Author

xrkffgg commented Jul 17, 2019 •
edited
Loading

NO3. commits tree

修复 tree 鼠标显示问题。不知道 是故意要做成这种效果还是什么？这里对鼠标做了一个小修复。

修复前效果：

修复后效果：

iamkun and others added 3 commits July 18, 2019 13:32
@iamkun
Chore: update theme base api (#16607)
11bf717
@iamkun @island205
Chore: Mark ali inner user's access (#16609)
e13de16 
* Chore: update theme inner api

* Chore: update theme inner api

* Chore: text

* Chore: fix

* Chore: fix
@xrkffgg
input : opt input readonly cursor css
dbf9db2
@xrkffgg
Copy link
Author

xrkffgg commented Jul 19, 2019

NO4. commits input

修改 input readonly 时，鼠标样式。

当设置el-input为readonly时，鼠标仍显示 输入状态，很容易造成歧义，强烈建议，增加input readonly时，鼠标显示默认状态。😞😞😞

ziyoung and others added 11 commits July 22, 2019 13:36
@ziyoung @island205
Calendar: Display correct header when range is specified (#16354)
adabeff 
* Calendar: display correct header when range is specified

* firstOfWeek is supported

* update docs

* update test

* update

* fix typo
@island205 @ziyoung
Select: Fix memory leak issue (#16463)
418ac5b
@luckyCao @ziyoung
Cascader: add sets default values when lazy is true (#16420)
9ee2fed
@iamkun @island205
Chore: Fix doc anchor bug (#16692)
e8483ac
@iamkun @island205
update inner check (#16700)
11417a3
@iamkun
Form: Add theme token (#16699)
c3765b4 
* add form label size token

* add form label size token
@iamkun
InfiniteScroll: Update naming & doc (#16698)
569c507
@ponkrit @iamkun
I18n: Update translation of Thai language (#16689)
f5b2fe1 
* I18n: Update translation of Thai language

* refactor(I18n): Update translation of Thai language & remove comment
@luckyCao @ziyoung
Avatar: fix image not center vertically issue (#16489)
2c7911e
@xrkffgg
transfer: 增加 button-queue 属性，默认为 left 表示 左在上，当设置该属性为 right 时，右在上
e48322e
@jw-foss @iamkun
Drawer: Add drawer component (#16577)
9617e93
@xrkffgg
Copy link
Author

xrkffgg commented Jul 24, 2019

NO5. commits transfer

根据
#16668

增加了 button-queue 属性，可控制 左右 button 的 上下 顺序

@xrkffgg xrkffgg mentioned this pull request Jul 24, 2019
Closed
@xrkffgg
Copy link
Author

xrkffgg commented Jul 24, 2019

😅😅😅

更新了一下 fork 的 代码 ，搞的越来越乱了

尴了个尬

@iamkun
Copy link
Member

iamkun commented Jul 31, 2019

这 commit 不太对呀 要不麻烦重新提交一个吧

@iamkun iamkun closed this Jul 31, 2019
@xrkffgg
Copy link
Author

xrkffgg commented Jul 31, 2019

@iamkun 大佬，一般一个 commit PR 是 单独一个功能吗？我是先提了一个，发了PR。然后再 加的，我以为会有新的PR，然后就越来越多了。。。。

@xrkffgg
Copy link
Author

xrkffgg commented Jul 31, 2019

@iamkun
之前，提交了5次。
分别是：

  1. input :文档中 size 我发现已经没有了 large，例子中还是有的。css 调整可以忽略。
  2. tree: 增加了一个 all-disabled 的属性，控制所有节点 禁用状态。
  3. tree: cursor的样式有点小问题，2.11.0 中仍然存在。可以看上面的忽略图。
  4. input: 修改了readonly 时，鼠标样式。
  5. Transfer: 根据 [Feature Request] how could i change transfer left button or right button order that determined which is on the top #16668 新增的。

大佬看下，觉得哪个需要改的，我再重新提吧。

@iamkun
Copy link
Member

iamkun commented Jul 31, 2019

我觉得要不你重新提一遍吧 一个 pr 修一个问题最好 不要出现别人的 commit

@xrkffgg
Copy link
Author

xrkffgg commented Jul 31, 2019

@iamkun 好的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xrkffgg @element-bot @iamkun @ziyoung @island205 @luckyCao @ponkrit @jw-foss