Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: enable keyup&keydown when there is no suggestions #17472

Closed
wants to merge 3 commits into from

Conversation

rickythink
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

已知问题

AutoComplete在type=textarea情况下时,键盘的上键和下键默认是prevent的。
示例:
https://codepen.io/RickyWong33/pen/ExYdypN?editors=1111

输入多行数据后,键盘上下键不可用。


修复

正确是做法时,出现suggestions提示框时,才prevent;不然保留原始的功能

@element-bot
Copy link
Member

element-bot commented Sep 18, 2019

Deploy preview for element ready!

Built with commit 2b8ec48

https://deploy-preview-17472--element.netlify.com

CarterLi added a commit to CarterLi/element that referenced this pull request Mar 28, 2020
1. add `@change` event
ElemeFE#17913
2. don't prevent when suggestions are not visible
ElemeFE#17472
3. allow `fetchSuggestions` returns a promise or an array
4. add `show-all-on-focus` prop
5. use tab for selection like enter
CarterLi added a commit to CarterLi/element that referenced this pull request Mar 28, 2020
1. add `@change` event
ElemeFE#17913
2. don't prevent when suggestions are not visible
ElemeFE#17472
3. allow `fetchSuggestions` returns a promise or an array
4. add `show-all-on-focus` prop
5. use tab for selection like enter
CarterLi added a commit to CarterLi/element that referenced this pull request Mar 30, 2020
1. add `@change` event
ElemeFE#17913
2. don't prevent when suggestions are not visible
ElemeFE#17472
3. allow `fetchSuggestions` returns a promise or an array
4. add `show-all-on-focus` prop
5. use tab for selection like enter
ZJL8 pushed a commit to EOITek/element that referenced this pull request Mar 30, 2020
1. add `@change` event
ElemeFE#17913
2. don't prevent when suggestions are not visible
ElemeFE#17472
3. allow `fetchSuggestions` returns a promise or an array
4. add `show-all-on-focus` prop
5. use tab for selection like enter
@stale
Copy link

stale bot commented Sep 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 18, 2020
@stale stale bot closed this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants