image: fix keyboard events handling logic #18416
Closed
+21
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.close #18393
main.vue line 221, manipulating document.body.style directly is not good, and events may propagate to a parent which are not body element, and still cause scrolling, so I use e.stopPropagation() on key events to stop scrolling instead of Image: Fix shield the page when preview big image (#16796) #16997.
image-viewer.vue line 295:
the mounted function only called once, cause reopen the image-viewer, all keyboard events and mouse scale events are not allowed. so add an prop 'visible' to solve this case.