Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils.dom): fix utils.dom error #21049

Merged
merged 1 commit into from
Jun 24, 2021
Merged

fix(utils.dom): fix utils.dom error #21049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function addClass(el, cls) {
}
}
if (!el.classList) {
el.className = curClass;
el.setAttribute('class', curClass);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setAttribute('class', curClass) 在 IE 下可能会不起作用。我手上没有 windows，你可以试下。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN上的描述看，是一直都可以设置class的。
image

在IE11上试了下，看着也没问题
image

}
};

Expand All @@ -112,7 +112,7 @@ export function removeClass(el, cls) {
}
}
if (!el.classList) {
el.className = trim(curClass);
el.setAttribute('class', trim(curClass));
}
};

Expand Down