upload: add before-remove function #8788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Leopoldthecoder Both Chinese and English document are updated. But I was not able to translate it to Spanish. So I just Keep it for others folks. |
firesh
force-pushed
the
dev-beforeRemove
branch
from
fa550b0 to
219de55
Compare
firesh
force-pushed
the
dev-beforeRemove
branch
from
219de55 to
d05ff36
Compare
packages/upload/src/index.vue
Outdated
| doRemove(); | ||
| }, () => { | ||
| // do nothing | ||
| }); |
There was a problem hiding this comment.
You can use noop here:
before.then(() => {
doRemove();
}, noop);
packages/upload/src/index.vue
Outdated
| doRemove(); | ||
| } else { | ||
| // do nothing | ||
| } |
There was a problem hiding this comment.
This else block can be removed entirely.
examples/docs/en-US/upload.md
Outdated
| handleBeforeRemove(file, fileList) { | ||
| return new Promise((resolve, reject) => { | ||
| if (confirm('It looks good, are you sure to remove?')) { | ||
| resolve() |
There was a problem hiding this comment.
Please add a semicolon here. Also applies to the other 7 resolve()s and reject()s.
|
Thanks for contributing. |
Leopoldthecoder
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload: add before-remove function. It can support a function returns a boolean or Promise.
#8399 requests this feature.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.