support input-number undefined value #9361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #9344 |
a-kriya
reviewed
Jan 19, 2018
| @@ -126,7 +124,7 @@ | |||
| }, | |||
| precision() { | |||
| const { value, step, getPrecision } = this; | |||
| return Math.max(getPrecision(value), getPrecision(step)); | |||
| return Math.max(getPrecision(value === undefined ? 0 : value), getPrecision(step)); | |||
There was a problem hiding this comment.
Why duplicate the === undefined check here when it is already performed inside the getPrecision function?
There was a problem hiding this comment.
thank, it's actually a duplicate work.
baiyaaaaa
force-pushed
the
feat-input-number
branch
from
b62f039 to
c71bf21
Compare
Leopoldthecoder
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.