Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table with rowKey's expandRows collapse when data change #9462

Merged
merged 1 commit into from
Jan 28, 2018

Conversation

furybean
Copy link
Contributor

@furybean furybean commented Jan 25, 2018

Fix #9317.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@@ -46,6 +46,7 @@ const toggleRowSelection = function(states, row, selected) {

const toggleRowExpansion = function(states, row, expanded) {
let changed = false;
console.log('toggleRowExpansion');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可删

@@ -405,6 +406,15 @@ TableStore.prototype.toggleRowExpansion = function(row, expanded) {
}
};

TableStore.prototype.isRowExpanded = function(row) {
const { expandRows = [], rowKey } = this.states.expandRows;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.states.expandRows => this.states

@furybean furybean force-pushed the fix-table-expansion branch from f8d3a0b to ae785f5 Compare January 26, 2018 06:31
@furybean
Copy link
Contributor Author

@Leopoldthecoder fixed.

@Leopoldthecoder Leopoldthecoder merged commit cfa9e6f into ElemeFE:dev Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants