Skip to content

Commit

Permalink
gui: Expose BitcoinGUI::unsubscribeFromCoreSignals
Browse files Browse the repository at this point in the history
Move only change that makes unsubscribeFromCoreSignals public. It must be
called if the event loop is not running otherwise core signals handlers
can deadlock.
  • Loading branch information
promag committed Feb 3, 2019
1 parent 60e190c commit 07b9aad
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/qt/bitcoingui.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ class BitcoinGUI : public QMainWindow
*/
bool hasTrayIcon() const { return trayIcon; }

/** Disconnect core signals from GUI client */
void unsubscribeFromCoreSignals();

protected:
void changeEvent(QEvent *e);
void closeEvent(QCloseEvent *event);
Expand Down Expand Up @@ -184,8 +187,6 @@ class BitcoinGUI : public QMainWindow

/** Connect core signals to GUI client */
void subscribeToCoreSignals();
/** Disconnect core signals from GUI client */
void unsubscribeFromCoreSignals();

/** Update UI with latest network info from model. */
void updateNetworkState();
Expand Down

0 comments on commit 07b9aad

Please sign in to comment.