Skip to content

Commit

Permalink
Remove no longer needed shellcheck suppressions
Browse files Browse the repository at this point in the history
  • Loading branch information
practicalswift committed Jan 16, 2019
1 parent 0b7196e commit a517541
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/lint/lint-shell.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ fi
# Disabled warnings:
disabled=(
SC1087 # Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
SC1117 # Backslash is literal in "\.". Prefer explicit escaping: "\\.".
SC2001 # See if you can use ${variable//search/replace} instead.
SC2004 # $/${} is unnecessary on arithmetic variables.
SC2005 # Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
Expand All @@ -36,7 +35,6 @@ disabled=(
SC2066 # Since you double quoted this, it will not word split, and the loop will only run once.
SC2086 # Double quote to prevent globbing and word splitting.
SC2116 # Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
SC2148 # Tips depend on target shell and yours is unknown. Add a shebang.
SC2162 # read without -r will mangle backslashes.
SC2166 # Prefer [ p ] {&&,||} [ q ] as [ p -{a,o} q ] is not well defined.
SC2181 # Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Expand Down

0 comments on commit a517541

Please sign in to comment.