disallow oversized CBlockHeaderAndShortTxIDs

Otherwise we'd reply with a bogus BlockTransactionsRequest trying to request indexes with overflowed deltas.
ElementsProject · Nov 13, 2018 · b08af10 · b08af10
1 parent 6bed4b3
commit b08af10
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/blockencodings.h b/src/blockencodings.h
@@ -186,6 +186,9 @@ class CBlockHeaderAndShortTxIDs {
 
         READWRITE(prefilledtxn);
 
+        if (BlockTxCount() > std::numeric_limits<uint16_t>::max())
+            throw std::ios_base::failure("indexes overflowed 16 bits");
+
         if (ser_action.ForRead())
             FillShortTxIDSelector();
     }