Use ToLower(...) instead of std::tolower

ElementsProject · Nov 6, 2018 · c5fd143 · c5fd143
1 parent e70cc89
commit c5fd143
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/uint256.cpp b/src/uint256.cpp
@@ -33,7 +33,7 @@ void base_blob<BITS>::SetHex(const char* psz)
  psz++;
 
  // skip 0x
- if (psz[0] == '0' && tolower(psz[1]) == 'x')
+ if (psz[0] == '0' && ToLower((unsigned char)psz[1]) == 'x')
  psz += 2;
 
  // hex string to uint

diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -422,7 +422,7 @@ bool ArgsManager::ParseParameters(int argc, const char* const argv[], std::strin
  key.erase(is_index);
  }
 #ifdef WIN32
- std::transform(key.begin(), key.end(), key.begin(), ::tolower);
+ std::transform(key.begin(), key.end(), key.begin(), ToLower);
  if (key[0] == '/')
  key[0] = '-';
 #endif

diff --git a/test/lint/lint-locale-dependence.sh b/test/lint/lint-locale-dependence.sh
@@ -15,10 +15,8 @@ KNOWN_VIOLATIONS=(
  "src/test/getarg_tests.cpp.*split"
  "src/torcontrol.cpp:.*atoi"
  "src/torcontrol.cpp:.*strtol"
- "src/uint256.cpp:.*tolower"
  "src/util/system.cpp:.*atoi"
  "src/util/system.cpp:.*fprintf"
- "src/util/system.cpp:.*tolower"
  "src/util/strencodings.cpp:.*atoi"
  "src/util/strencodings.cpp:.*strtol"
  "src/util/strencodings.cpp:.*strtoul"