Skip to content

Commit

Permalink
Merge #15013: test: Avoid race in p2p_timeouts
Browse files Browse the repository at this point in the history
fabcd64 test: Avoid racy test p2p_timeouts (MarcoFalke)

Pull request description:

  Avoid filesystem/network racyness by sleeping another second. The alternative would be to poll the `debug.log`, but that seems overkill to avoid a sleep in a test that already requires them.

Tree-SHA512: 32de75ecba38426323158fda241e37ffae73806d8c0e60b7ad73fb917e9cd25a3e5f0722cbc6f2f7a5b86501221c317783266bc2e3b4697fb120f05898ccc12d
  • Loading branch information
MarcoFalke committed Dec 21, 2018
2 parents feda41e + fabcd64 commit cc7ad2f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/functional/p2p_timeouts.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ def run_test(self):
]

with self.nodes[0].assert_debug_log(expected_msgs=expected_timeout_logs):
sleep(2)
sleep(3)
# By now, we waited a total of 5 seconds. Off-by-two for two
# reasons:
# * The internal precision is one second
# * Account for network delay
assert not no_verack_node.is_connected
assert not no_version_node.is_connected
assert not no_send_node.is_connected
Expand Down

0 comments on commit cc7ad2f

Please sign in to comment.