Skip to content

Commit

Permalink
Docs: Update python docs to reflect that wildcard imports are disallowed
Browse files Browse the repository at this point in the history
  • Loading branch information
Empact committed Jan 25, 2019
1 parent 72bd4ab commit f618c58
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/functional/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ don't have test cases for.
The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
- See [the python lint script](/test/lint/lint-python.sh) that checks for violations that
could lead to bugs and issues in the test code.
- Avoid wildcard imports where possible
- Avoid wildcard imports
- Use a module-level docstring to describe what the test is testing, and how it
is testing it.
- When subclassing the BitcoinTestFramwork, place overrides for the
Expand Down
2 changes: 1 addition & 1 deletion test/functional/example_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# libraries then local imports).
from collections import defaultdict

# Avoid wildcard * imports if possible
# Avoid wildcard * imports
from test_framework.blocktools import (create_block, create_coinbase)
from test_framework.messages import CInv
from test_framework.mininode import (
Expand Down

0 comments on commit f618c58

Please sign in to comment.