Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walletcreatefundedpsbt needs to (optionally) add explicit value fields #1179

Closed
philippem opened this issue Sep 27, 2022 · 1 comment · Fixed by #1186
Closed

walletcreatefundedpsbt needs to (optionally) add explicit value fields #1179

philippem opened this issue Sep 27, 2022 · 1 comment · Fixed by #1186

Comments

@philippem
Copy link
Contributor

philippem commented Sep 27, 2022

In a recent change to the PSET spec, new input keys were added to support the communication of unblinded values, for the benefit of resource-constrained environments. See the requesting issue #1153

The new input keys are

PSBT_ELEMENTS_IN_EXPLICIT_VALUE
PSBT_ELEMENTS_IN_VALUE_PROOF
PSBT_ELEMENTS_IN_EXPLICIT_ASSET
PSBT_ELEMENTS_IN_ASSET_PROOF
PSBT_ELEMENTS_IN_BLINDED_ISSUANCE

Support for these keys was added in the PRs

#1157
#1165

The current walletcreatefundedpsbt RPC does not set these fields in its response, nor provides a way for the caller of the RPC to request that they be populated (possibly by using the 4th optional options argument).

To reproduce

See the test vector generator provided at
https://github.com/miketlk/testvectors/blob/ca7a6a2f00a61d881168a2ae498fee05e130c1fe/tests/test_pset.py#L123-L146

System information

elementsd commit e0c911a on elements-22.x branch

@apoelstra
Copy link
Member

cc @achow101 can you add an option to walletcreatefundedpsbt to populate these fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants