Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_explicit to walletcreatefundedpsbt #1186

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

achow101
Copy link
Contributor

Fixes #1179

Make these two functions available to external callers.
CreateBlindValueProof is a wrapper around the static function to avoid
requiring callers to parse things into secp256k1 objects.
@apoelstra
Copy link
Member

This looks great! Can you add another test commit which explicitly checks the test vector linked in #1179?

@achow101
Copy link
Contributor Author

The linked test vector is not a fixed test vector. The included tests already do basically what that does.

@gwillen
Copy link
Contributor

gwillen commented Oct 24, 2022

utACK

@psgreco psgreco merged commit 58b5fa0 into ElementsProject:master Nov 21, 2022
jamesdorfman added a commit to jamesdorfman/elements that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

walletcreatefundedpsbt needs to (optionally) add explicit value fields
4 participants