simplicity: activate on first week of unanimous signalling after block 3333333 #1427
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psgreco
force-pushed
the
2025-03--simplicity-activation
branch
from
fa02ff7 to
fcf644e
Compare
apoelstra
force-pushed
the
2025-03--simplicity-activation
branch
from
fcf644e to
fa02ff7
Compare
|
Rebased. (My diff is identical to Pablo's rebase, but mine has a gpg signature from me on it.) |
apoelstra
force-pushed
the
2025-03--simplicity-activation
branch
from
fa02ff7 to
816a39e
Compare
|
Just remembered that we interpret nStartTime as a block height, not a timestamp elements/src/consensus/params.h Line 50 in 246a764 |
|
Liquidv1 has passed block 3333333 yesterday which would make a neat/memorable start height |
|
Oof, good catch! |
apoelstra
force-pushed
the
2025-03--simplicity-activation
branch
from
816a39e to
6e1854f
Compare
…k 3333333 This block passed on April 14 (so we will activate as soon as this is merged and there is a week of unaminous signalling), and its a nice memorable number.
apoelstra
force-pushed
the
2025-03--simplicity-activation
branch
from
6e1854f to
308a393
Compare
delta1
approved these changes
Apr 15, 2025
psgreco
changed the title
delta1
added a commit
to delta1/elements
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply starts signalling for Simplicity in any blocksigner that has it enabled. Once we have one week (10080 blocks) of unanimous signalling, then it activates.