Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard wallet code in pow.cpp with ENABLE_WALLET #22

Merged
merged 1 commit into from
Jun 12, 2015

Conversation

pstratem
Copy link
Contributor

Include missing ENABLE_WALLET guards to avoid building wallet/including bdb if --disable-wallet is specified.

@jtimon
Copy link
Contributor

jtimon commented Jun 12, 2015

ut ACK

@pstratem pstratem merged commit f226262 into ElementsProject:alpha Jun 12, 2015
pstratem added a commit that referenced this pull request Jun 12, 2015
f226262 Guard wallet code in pow.cpp with ENABLE_WALLET (Patrick Strateman)
martindale pushed a commit to martindale/elements that referenced this pull request Feb 20, 2017
daf1285 Merge pull request ElementsProject#2 from jgarzik/master
d9e62d3 Merge pull request ElementsProject#24 from MarcoFalke/Mf1608-cleanup
faf260f Rem unused vars and prefer prefix operator for non-primitive type
09a2693 Merge pull request ElementsProject#22 from laanwj/2016_04_unicode
c74a04c Merge pull request ElementsProject#23 from paveljanik/20160527_Wshadow
fceb4f8 Do not shadow variables

git-subtree-dir: src/univalue
git-subtree-split: daf1285af60c2c73801c0f41469c9802c849343d
gwillen pushed a commit that referenced this pull request Mar 19, 2021
…odal overlay is shown

d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes #22.

  ---

  On master (ca05588):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
Mixa84 added a commit to SequentiaSEQ/sequentia that referenced this pull request Oct 30, 2024
Turn on tests in workflow, and fix rpc_help.py test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants