Add report_error function for peer errors which can be overridden
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe have a command line parameter that specifies a shell command to execute? |
|
@maaku I think rather than a shell command I should move the function into |
apoelstra
force-pushed
the
report-error
branch
from
c301a0a
to
efadb28
Compare
|
Does this still make sense in the rebased https://github.com/ElementsProject/elements/commits/elements-0.13.1 ? do we still want this for alpha? |
|
This doesn't make any sense for 0.13.1 since it's not using the python
federation scripts.
…On Thu, Apr 27, 2017 at 8:48 AM, Jorge Timón ***@***.***> wrote:
Does this still make sense in the rebased https://github.com/
ElementsProject/elements/commits/elements-0.13.1 ? do we still want this
for alpha?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgC04R5u3cCgGOlxu28W4WTmopn1MkBks5r0I6cgaJpZM4F7_H7>
.
|
|
Merge or close? |
|
Closing all alpha open PRs for clarity. We can always reopen them if this is a mistake. |
delta1
pushed a commit
to delta1/elements
that referenced
this pull request
Apr 28, 2023
0d624261ef Merge bitcoin-core/crc32c-subtree#2: Merge upstream cac7ca830b Merge commit 'fa5ade41ee480003d9c5af6f43567ba22e4e17e6' into bitcoin-fork fa5ade41ee Fix compilation warnings on ARM64 with old GCC versions. (ElementsProject#52) db08d22129 Updated Travis-CI configuration. (ElementsProject#51) e31619a5b7 Fix GitHub links. (ElementsProject#50) 7fa4c263e8 Update Travis CI config. (ElementsProject#49) a3d9e6d1a4 Updated third_party/ and Travis CI config. (ElementsProject#48) git-subtree-dir: src/crc32c git-subtree-split: 0d624261ef83ab08c953c196540ed18f355add4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly which errors should go through this function rather than being
printed directly; the idea is that these messages are ones that indicate network/peer problems that should be addressed immediately.