gui: Make balances scrollable on overview #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work, thanks |
|
got another out of band tACK |
stevenroose
added a commit
that referenced
this pull request
Nov 26, 2019
ead03a8 Make balances in overview scrollable (Andrew Chow) 3743ff5 Set the vertical layout in .ui file instead of programatically (Andrew Chow) Pull request description: Makes the balances on the overview page scrollable when therer are lots of assets. It should be both vertically and horizontally scrollable. Also Fixes the vertical layout so it uses the UI forms and looks better. Fixes #685 Tree-SHA512: 19f4c2ded210b2e969a64ead2ff1e16076f724c994a223d3edd15dcd758729069f68f4cab746c6b06fe6d384f64868efd6babe735995f3adb61ce137a469a369
instagibbs
added a commit
that referenced
this pull request
Nov 26, 2019
eedb834 Fix address string assertions in tests (Gregory Sanders) 791c53b Remove 'bitcoin' from address descriptions (Gregory Sanders) e5c1ad8 Fill out expected liquidv1 chain size (Gregory Sanders) 615be7f Fix QR address display for blinded base58 addrs (Gregory Sanders) 59d6b9f Make balances in overview scrollable (Andrew Chow) 921cddf Set the vertical layout in .ui file instead of programatically (Andrew Chow) Pull request description: backports of: - #788 - #785 - #784 - #778 Tree-SHA512: a6d7844fb2caf7430cd2d7dc8a6229346e7aee25bc8bd24415b0aae340f4e4762dd559fd507397a19bb960fb67d86b9e8d58e49726e04417fa9e195a84e51062
stevenroose
pushed a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the balances on the overview page scrollable when therer are lots of assets. It should be both vertically and horizontally scrollable.
Also Fixes the vertical layout so it uses the UI forms and looks better.
Fixes #685